netdev - Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to readout chip temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190413175105.GO17901@lunn.ch>
Date:   Sat, 13 Apr 2019 19:51:05 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
        Yana Esina <yana.esina@...antia.com>
Subject: Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to
 readout chip temperature

On Sat, Apr 13, 2019 at 12:31:43PM +0000, Igor Russkikh wrote:
> From: Yana Esina <yana.esina@...antia.com>
> 
> Ability to read the chip temperature from memory
> via hwmon interface

> +	/* Convert PHY temperature from 1/256 degree Celsius
> +	 * to 1/1000 degree Celsius.
> +	 */
> +	*temp = temp_res  * 1000 / 256;
> +
> +	return 0;
> +}

Hi Igor, Yana

Is this a single chip MAC/PHY, or is there a discrete PHY?

If this is not a single chip solution, maybe this should be called
get_phy_temp, so you can later add a get_mac_temp.

      Andrew