[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190413181406.GR17901@lunn.ch>
Date: Sat, 13 Apr 2019 20:14:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Igor Russkikh <Igor.Russkikh@...antia.com>
Cc: "David S . Miller" <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Nikita Danilov <Nikita.Danilov@...antia.com>,
Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
Yana Esina <yana.esina@...antia.com>
Subject: Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to
readout chip temperature
On Sat, Apr 13, 2019 at 07:51:05PM +0200, Andrew Lunn wrote:
> On Sat, Apr 13, 2019 at 12:31:43PM +0000, Igor Russkikh wrote:
> > From: Yana Esina <yana.esina@...antia.com>
> >
> > Ability to read the chip temperature from memory
> > via hwmon interface
>
> > + /* Convert PHY temperature from 1/256 degree Celsius
> > + * to 1/1000 degree Celsius.
> > + */
> > + *temp = temp_res * 1000 / 256;
> > +
> > + return 0;
> > +}
Hi Igor, Yana
To bring this up to par with the aquantia PHY driver, you might want
to also export the high/low warn and fail temperatures.
Andrew
Powered by blists - more mailing lists