netdev - Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to readout chip temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Apr 2019 18:16:32 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
        Yana Esina <yana.esina@...antia.com>
Subject: Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to
 readout chip temperature


Hi Andrew,

> Is this a single chip MAC/PHY, or is there a discrete PHY?
> 
> If this is not a single chip solution, maybe this should be called
> get_phy_temp, so you can later add a get_mac_temp.

Thats a single chip with integrated mac/phy.
I however double checked it, and see phy and mac report temperatures separately.
So its really better to name it phy_temp. And I'll investigate on mac_temp later.

> To bring this up to par with the aquantia PHY driver, you might want
> to also export the high/low warn and fail temperatures.

Ok, will investigate this.

Regards, Igor