netdev - Re: iproute2 broken vlan stats output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJieiUiYQh-NhdbPpX_4ee16KBYtYRUHaZVqUVJ6mRJyDQncFg@mail.gmail.com>
Date:   Tue, 16 Apr 2019 07:28:33 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        network dev <netdev@...r.kernel.org>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: iproute2 broken vlan stats output

On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
>
> Hi Stephen,
> It seems standard (non-json) vlan stats output has been broken since commit:
>  0f36267485e3 ("bridge: fix vlan show formatting")
>
> bridge -s vlan show output before commit 0f36267485e3:
> port             vlan id
> br0              1 PVID untagged
>                    RX: 0 bytes 0 packets
>                    TX: 0 bytes 0 packets
> eth4             1 PVID untagged
>                    RX: 0 bytes 0 packets
>                    TX: 0 bytes 0 packets
>
> bridge -s vlan show output after commit 0f36267485e3:
> root@...ian~/# bridge -s vlan
> port             vlan id
> br0br0              1 PVID Egress Untagged
>                    RX: 0 bytes 0 packets
>                    TX: 0 bytes 0 packetseth4eth4             1 PVID Egress Untagged
>                    RX: 0 bytes 0 packets
>                    TX: 0 bytes 0 packetsroot@...ian:~/#
>

:(. Looks like iproute2 should have selftests too. Its hard to catch
these in code review.