netdev - Re: iproute2 broken vlan stats output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2da90287-6526-5523-9e58-7f00a9dd1781@cumulusnetworks.com>
Date:   Tue, 16 Apr 2019 17:33:47 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        network dev <netdev@...r.kernel.org>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: iproute2 broken vlan stats output

On 16/04/2019 17:28, Roopa Prabhu wrote:
> On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov
> <nikolay@...ulusnetworks.com> wrote:
>>
>> Hi Stephen,
>> It seems standard (non-json) vlan stats output has been broken since commit:
>>  0f36267485e3 ("bridge: fix vlan show formatting")
>>
>> bridge -s vlan show output before commit 0f36267485e3:
>> port             vlan id
>> br0              1 PVID untagged
>>                    RX: 0 bytes 0 packets
>>                    TX: 0 bytes 0 packets
>> eth4             1 PVID untagged
>>                    RX: 0 bytes 0 packets
>>                    TX: 0 bytes 0 packets
>>
>> bridge -s vlan show output after commit 0f36267485e3:
>> root@...ian~/# bridge -s vlan
>> port             vlan id
>> br0br0              1 PVID Egress Untagged
>>                    RX: 0 bytes 0 packets
>>                    TX: 0 bytes 0 packetseth4eth4             1 PVID Egress Untagged
>>                    RX: 0 bytes 0 packets
>>                    TX: 0 bytes 0 packetsroot@...ian:~/#
>>
> 
> :(. Looks like iproute2 should have selftests too. Its hard to catch
> these in code review.
> 

I made a mistake about the commit, the actual culprits are:
     45fca4ed9412 ("bridge: fix vlan show stats formatting")
     c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
They both broke a different thing about standard stats output:
   - 45fca4ed9412 ("bridge: fix vlan show stats formatting")
     Added a second print of an interface name (e.g. eth4eth4)
   - c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
     Broke normal vlan stats output by not printing a new line after them

I'll post a fix in a minute.