netdev - Re: Question re. skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416150002.cbkih4lfrna4ywdu@breakpoint.cc>
Date:   Tue, 16 Apr 2019 17:00:02 +0200
From:   Florian Westphal <fw@...len.de>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: Question re. skb_orphan for TPROXY

Lorenz Bauer <lmb@...udflare.com> wrote:
> Apologies for contacting you out of the blue. I'm currently trying to
> understand how TPROXY works under the hood. As part of this endeavour,
> I've stumbled upon the commit attached to this email.
> 
> From the commit message I infer that somewhere, TPROXY relies on a
> check of skb->sk == NULL to function. However, I can't figure out
> where! I've traced TPROXY from NF_HOOK(NF_INET_PRE_ROUTING) just after
> the call to skb_orphan to __inet_lookup_skb / skb_steal_sock called
> from the TCP and UDP receive functions, and as far as I can tell there
> is no such check. Can you maybe shed some light on this?

Without the skb_orphan udp/tcp might steal tunnel/ppp etc. socket
instead of tproxy assigned tcp/udp socket.