netdev - Re: [PATCH net-next 12/13] ipv6: Pass fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <093ba6d7-dd65-0270-2eea-5760f7c7b013@gmail.com>
Date:   Tue, 16 Apr 2019 09:00:58 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Ahern <dsahern@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     idosch@...lanox.com
Subject: Re: [PATCH net-next 12/13] ipv6: Pass fib6_result to fib lookups

On 4/15/19 6:56 PM, David Ahern wrote:
> @@ -182,14 +178,10 @@ static int fib6_rule_action_alt(struct fib_rule *rule, struct flowi *flp,
>  		return -EAGAIN;
>  
>  	oif = (int *)arg->lookup_data;
> -	f6i = fib6_table_lookup(net, table, *oif, flp6, flags);
> -	if (f6i != net->ipv6.fib6_null_entry) {
> +	err = fib6_table_lookup(net, table, *oif, flp6, res, flags);
> +	if (!err && res->f6i != net->ipv6.fib6_null_entry)
>  		err = fib6_rule_saddr(net, rule, flags, flp6,
> -				      fib6_info_nh_dev(f6i));
> -
> -		if (likely(!err))
> -			arg->result = f6i;
> -	}
> +				      fib6_info_nh_dev(res->f6i));

that is supposed to be res->nh, not fib6_info_nh_dev(res->f6i).

Will fix and send a v2.