netdev - Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 08:43:06 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Patrick McHardy <kaber@...sh.net>,
        Jiri Benc <jbenc@...hat.com>, stefan.sorensen@...ctralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP
 ioctl to real device

On Wed, Apr 17, 2019 at 04:05:09PM +0800, Hangbin Liu wrote:
> On the other hand, Miroslav pointed that with NET_ADMIN enabled in container,
> a normal user could be mapped to root and is able to change the real devices's
> rx filter via ioctl on macvlan, which may affect the other ptp process on
> host. ptp over vlan also has this issue, but macvlan is more frequently used
> in container.

If NET_ADMIN is enabled in the container, don't the host and container
contend with each other for the physical interfaces anyhow?

(I'm not a container person, so forgive my ignorance.)

Thanks,
Richard