netdev - Re: [PATCH iproute2] ip: add missing space after 'external' in detailed mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190417163349.19348c1d@hermes.lan>
Date:   Wed, 17 Apr 2019 16:33:49 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Beniamino Galvani <bgalvani@...hat.com>
Cc:     netdev@...r.kernel.org, Andrea Claudi <aclaudi@...hat.com>,
        Serhey Popovych <serhe.popovych@...il.com>
Subject: Re: [PATCH iproute2] ip: add missing space after 'external' in
 detailed mode

On Tue, 16 Apr 2019 16:04:39 +0200
Beniamino Galvani <bgalvani@...hat.com> wrote:

> Add a missing space after the 'external' keyword in the detailed mode
> of tunnel links output:
> 
>  # ip -d link
>  79: geneve1: <BROADCAST,MULTICAST> mtu 65465 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/ether da:e9:e4:2b:f9:d4 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65465
>      geneve externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>  80: vxlan1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/ether 7a:a8:19:07:da:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535
>      vxlan externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>  84: gre1@...E: <NOARP> mtu 1476 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/none 00:00:00:00 brd 00:00:00:00 promiscuity 0 minmtu 0 maxmtu 0
>      gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>  87: ip6gre1@...E: <NOARP> mtu 1448 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/gre6 :: brd :: promiscuity 0 minmtu 0 maxmtu 0
>      ip6gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>  88: ip6tnl1@...E: <NOARP> mtu 1452 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/tunnel6 :: brd :: promiscuity 0 minmtu 68 maxmtu 65407
>      ip6tnl externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>  90: ipip1@...E: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>      link/ipip 0.0.0.0 brd 0.0.0.0 promiscuity 0 minmtu 0 maxmtu 0
>      ipip externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> 
> Fixes: 00ff4b8e31af ("ip/tunnel: Be consistent when printing tunnel collect metadata")
> Reviewed-and-tested-by: Andrea Claudi <aclaudi@...hat.com>
> Signed-off-by: Beniamino Galvani <bgalvani@...hat.com>

Applied, thanks.