netdev - Re: [PATCH iproute2 v2] bridge: vlan: fix standard stats output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190417163438.663873ec@hermes.lan>
Date:   Wed, 17 Apr 2019 16:34:38 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH iproute2 v2] bridge: vlan: fix standard stats output

On Tue, 16 Apr 2019 18:30:12 +0300
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> Each of the commits below broke the vlan stats output in a different
> way:
> - 45fca4ed9412 ("bridge: fix vlan show stats formatting")
>  Added a second print of an interface name (e.g. eth4eth4)
> - c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
>  Broke normal vlan stats output by not printing a new line after them
>  Also printed interfaces without any vlans when printing stats
> 
> This fix is not pretty but it brings back the previous behaviour.

Ok, applied.
The output format here makes it hard to code.