netdev - RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR11MB39530B69C9BD75927F1F61B89F250@BN6PR11MB3953.namprd11.prod.outlook.com>
Date:   Wed, 17 Apr 2019 03:49:46 +0000
From:   <RaghuramChary.Jallipalli@...rochip.com>
To:     <Jisheng.Zhang@...aptics.com>, <andrew@...n.ch>,
        <f.fainelli@...il.com>
CC:     <marc.zyngier@....com>, <Woojung.Huh@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

Hi Jisheng,

> > I want to understand if there is any functionality impact with this warning?
> Because I'm afraid if the current changes are removed we might hit some
> other issues (or older ones). We have to go through rigorous testing before
> going ahead.
> 
> Warning indicates there's something wrong in the code.

Agree that the code is incorrect. Just wanted to understand if you had any functionality impact too.

> 
> IMHO phy_mac_interrupt() and PHY_IGNORE_INTERRUPT is the correct
> solution. If the phy_mac_interrupt() poll is fixed, I think maybe old issue
> which commit cc89c323a30e want to fix won't exist.
> 

I tried to reproduce the problem in PC environment but did not see the warnings. 
However, I tried your patch and did plug/unplug tests(rmmod/insmod continuously) and observed call traces from kernel. I don't see these traces without your patch.
Attached log.

Thanks,
-Raghu


Download attachment "log7800_withpatch" of type "application/octet-stream" (29417 bytes)