netdev - Re: [PATCH v1 2/3] MIPS: ath79: ar9331: add Ethernet nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 11:50:42 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>,
        Paul Burton <paul.burton@...s.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jay Cliburn <jcliburn@...il.com>,
        Chris Snook <chris.snook@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Mark Rutland <mark.rutland@....com>
Cc:     Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, John Crispin <john@...ozen.org>,
        Felix Fietkau <nbd@....name>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 2/3] MIPS: ath79: ar9331: add Ethernet nodes

Hello!

On 17.04.2019 9:22, Oleksij Rempel wrote:

> Add ethernet nodes supported by ag71xx driver.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>   arch/mips/boot/dts/qca/ar9331.dtsi           | 25 ++++++++++++++++++++
>   arch/mips/boot/dts/qca/ar9331_dpt_module.dts |  8 +++++++
>   2 files changed, 33 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/qca/ar9331.dtsi b/arch/mips/boot/dts/qca/ar9331.dtsi
> index 2bae201aa365..7d59c7c66dda 100644
> --- a/arch/mips/boot/dts/qca/ar9331.dtsi
> +++ b/arch/mips/boot/dts/qca/ar9331.dtsi
> @@ -116,6 +116,31 @@
>   			};
>   		};
>   
> +		eth0: eth@...00000 {

    The name should be "ethernet@...> according to the DT spec.

> +			status = "disabled";

    Mmm, this one is typically specified last in the node.

> +
> +			compatible = "qca,ar9330-eth";
> +			reg = <0x19000000 0x200>;
> +			interrupts = <4>;
> +
> +			resets = <&rst 9>;
> +			reset-names = "mac";
> +		};
> +
> +		eth1: eth@...00000 {

    "ethernet@..." again.

> +			status = "disabled";
> +
> +			compatible = "qca,ar9330-eth";
> +			reg = <0x1a000000 0x200>;
> +			interrupts = <5>;
> +
> +			resets = <&rst 13>, <&rst 23>;
> +			reset-names = "mac", "mdio";
> +
> +			clocks = <&pll ATH79_CLK_MDIO>;
> +			clock-names = "mdio";
> +		};
> +
>   		usb: usb@...00100 {
>   			compatible = "chipidea,usb2";
>   			reg = <0x1b000000 0x200>;
[...]

MBR, Sergei