netdev - Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418101722.19af3467@cakuba.netronome.com>
Date:   Thu, 18 Apr 2019 10:17:22 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to
 contain per-dev(asic) items

On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> The existing devlink.c code is going to be extended to represent asic
> device on a bus. As this is about more than just devlink,
> rename the file. Do appropriate prefix renaming alongside with that.

Again, devlink != bus device.  I don't like this change at all.

Keep them separate, please, unless you _need_ such a change for testing.