netdev - Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418102550.6eea3255@cakuba.netronome.com>
Date:   Thu, 18 Apr 2019 10:25:50 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next 14/15] netdevsim: move netdev
 creation/destruction to dev probe

On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote:
> @@ -1279,24 +1312,13 @@ try:
>      start_test("Test multi-dev ASIC cross-dev destruction...")
>      bpftool_prog_list_wait(expected=2)
>  
> -    simA.remove()
> +    simdevA.remove()
>      bpftool_prog_list_wait(expected=1)
>  
>      ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]
>      fail(ifnameB != simB1['ifname'], "program not bound to originial device")
> -    simB1.remove()
> -    bpftool_prog_list_wait(expected=1)
> -
> -    start_test("Test multi-dev ASIC cross-dev destruction - move...")
> -    ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]
> -    fail(ifnameB not in (simB2['ifname'], simB3['ifname']),
> -         "program not bound to remaining devices")
> -
> -    simB2.remove()
> -    ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"]
> -    fail(ifnameB != simB3['ifname'], "program not bound to remaining device")
>  
> -    simB3.remove()
> +    simdevB.remove()
>      bpftool_prog_list_wait(expected=0)
>  
>      start_test("Test multi-dev ASIC cross-dev destruction - orphaned...")

You're removing existing tests in the name of reshuffling the code?

Hard no.

Once devlink can do what we need here, we can reorg netdevsim.
netdevsim is for testing real interfaces.