netdev - Re: [PATCH net-next] net: phy: don't set autoneg if it's not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Apr 2019 16:28:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: don't set autoneg if it's not
 supported

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 16 Apr 2019 23:54:00 +0200

> In phy_device_create() we set phydev->autoneg = 1. This isn't changed
> even if the PHY doesn't support autoneg. This seems to affect very
> few PHY's, and they disable phydev->autoneg in their config_init
> callback. So it's more of an improvement, therefore net-next.
> The patch also wouldn't apply to older kernel versions because the
> link mode bitmaps have been introduced recently.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.