netdev - Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190418.163042.247858083459593509.davem@davemloft.net>
Date:   Thu, 18 Apr 2019 16:30:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: bcm87xx: improve feature
 configuration

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 17 Apr 2019 00:06:28 +0200

> This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be
> able to remove this predefined feature constant later. Setting
> phydev->advertising to what is supported is done by phy_probe(),
> therefore we don't have to do it in the config_init callback.
> Resetting phydev->autoneg if autoneg isn't supported is also done by
> phy_probe() now, and manually setting the phylib state machine to
> NOLINK is neither needed nor advisable.
> In addition propagate the return value of bcm87xx_of_reg_init.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

I read the discussion on this patch, there doesn't seem to be outright
NACK but rather some talk about future enhancements and something about
Florian looking at a few datasheets next week.

What's the story?