netdev - Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 20:31:57 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Patrick McHardy <kaber@...sh.net>,
        stefan.sorensen@...ctralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP
 ioctl to real device

On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote:
> The problem here is this patch gives access to physical interface
> settings through a virtual interface layered on top of it. Whenever
> such thing is done, the virtual interface needs to provide a suitable
> way of moderating access to the shared resources, so the individual
> virtual interfaces do not affect each other. That's not what's being
> done here.

So I guess the macvlan should reject SIOCSHWTSTAMP but allow
SIOCGHWTSTAMP.
 
> I think this patch is wrong.

But what about this statement:

    ptp over vlan also has this issue

What is the issue with VLAN interfaces?  Are these exportable to a
container when the physical interface is not?

Thanks,
Richard