netdev - Re: [PATCH net-next 11/15] dsa: Add stub tag driver put method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0eaf546e-7658-51bd-6621-4e7cbc06c53a@gmail.com>
Date:   Fri, 19 Apr 2019 08:32:44 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 11/15] dsa: Add stub tag driver put method



On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> When a DSA switch driver is unloaded, the lock on the tag driver
> should be released so the module can be unloaded. Add the needed calls,
> but leave the actual relase code as a stub.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

[snip]

> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
> index ba91bda8bdd3..efc51a9dc9c8 100644
> --- a/net/dsa/dsa2.c
> +++ b/net/dsa/dsa2.c
> @@ -335,6 +335,8 @@ static void dsa_port_teardown(struct dsa_port *dp)
>  	case DSA_PORT_TYPE_UNUSED:
>  		break;
>  	case DSA_PORT_TYPE_CPU:
> +		dsa_tag_driver_put(dp->tag_ops);
> +		/* fall thought */

Typo: s/fall thought/fall through/

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian