netdev - Re: [PATCH net-next 14/15] dsa: Allow tag drivers to be built as modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35ee991a-4862-995b-6f50-1312245c1c78@gmail.com>
Date:   Fri, 19 Apr 2019 08:38:11 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 14/15] dsa: Allow tag drivers to be built as
 modules



On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> Make the CONFIG symbols tristate and add help text.
> 
> The broadcom and Microchip KSZ tag drivers support two different
> tagging protocols in one driver. Add a configuration option for the
> drivers, and then options to select the protocol.
> 
> Create a submenu for the tagging drivers.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

[snip]

>  
> -# tagging formats
> +config NET_DSA_TAG_BRCM_COMMON
> +       tristate "Tag driver for Broadcom switch"
> +	help
> +          Say Y or M if you want to enable support for tagging frames
> +	  for the Broadcom switches.

The indentation between the tristate and help lines seems to be off a
little bit with spaces vs. tabs. This particular Kconfig symbol should
probably be hidden and selected by NET_DSA_TAG_BRCM and
NET_DSA_TAG_BRCM_PREPEND.

> +
>  config NET_DSA_TAG_BRCM
> -	bool
> +	bool "Tag driver for Broadcom switch using in frame headers"

Plural: switches

> +	depends on NET_DSA_TAG_BRCM_COMMON
> +	help
> +	  Say Y if you want to enable support for tagging frames for the
> +	  Broadcom switches which place the tag after the MAC addresses.

After the MAC source address.

> +
>  
>  config NET_DSA_TAG_BRCM_PREPEND
> -	bool
> +	bool "Tag driver for Broadcom switches using prepended headers"
> +	depends on NET_DSA_TAG_BRCM_COMMON
> +	help
> +	  Say Y if you want to enable support for tagging frames for the
> +	  Broadcom switches which preprended headers.

Which places the tag before the Ethernet header (prepended).
-- 
Florian