lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Apr 2019 23:29:42 -0400 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: "David S. Miller" <davem@...emloft.net> CC: <netdev@...r.kernel.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Yotam Gigi <yotam.gi@...il.com> Subject: [PATCH 1/7] net: psample: drop include of module.h from psample.h Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP. The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support. There doesn't appear to be anything in psample.h that is module related, and build coverage doesn't appear to show any other files/drivers relying implicitly on getting it from here. So it appears we are simply free to just remove it in this case. Cc: Yotam Gigi <yotam.gi@...il.com> Cc: "David S. Miller" <davem@...emloft.net> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> --- include/net/psample.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/psample.h b/include/net/psample.h index 9b80f814ab04..37a4df2325b2 100644 --- a/include/net/psample.h +++ b/include/net/psample.h @@ -3,7 +3,6 @@ #define __NET_PSAMPLE_H #include <uapi/linux/psample.h> -#include <linux/module.h> #include <linux/list.h> struct psample_group { -- 2.7.4
Powered by blists - more mailing lists