lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 20 Apr 2019 23:29:41 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Daniel Wagner <daniel.wagner@...-carit.de>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, Martin KaFai Lau <kafai@...com>,
        "Rosen, Rami" <rami.rosen@...el.com>,
        Song Liu <songliubraving@...com>, Tejun Heo <tj@...nel.org>,
        Yonghong Song <yhs@...com>, Yotam Gigi <yotam.gi@...il.com>
Subject: [PATCH -next 0/7] clean up needless use of module infrastructure

People can embed modular includes and modular exit functions into code
that never use any of it, and they won't get any errors or warnings.

Using modular infrastructure in non-modules might seem harmless, but some
of the downfalls this leads to are:

 (1) it is easy to accidentally write unused module_exit removal code
 (2) it can be misleading when reading the source, thinking a driver can
     be modular when the Makefile and/or Kconfig prohibit it
 (3) an unused include of the module.h header file will in turn
     include nearly everything else; adding a lot to CPP overhead.
 (4) it gets copied/replicated into other drivers and spreads quickly.

As a data point for #3 above, an empty C file that just includes the
module.h header generates over 750kB of CPP output.  Repeating the same
experiment with init.h and the result is less than 12kB; with export.h
it is only about 1/2kB; with both it still is less than 12kB.  One driver
in this series gets the module.h ---> init.h+export.h conversion.

Worse, are headers in include/linux that in turn include <linux/module.h>
as they can impact a whole fleet of drivers, or a whole subsystem, so
special care should be used in order to avoid that.  Such headers should
only include what they need to be stand-alone; they should not be trying
to anticipate the various header needs of their possible end users.

In this series, four include/linux headers have module.h removed from
them because they don't strictly need it.  Then three chunks of net
related code have modular infrastructure that isn't used, removed.

There are no runtime changes, so the biggest risk is a genuine consumer
of module.h content relying on implicitly getting it from one of the
include/linux instances removed here - thus resulting in a build fail.

With that in mind, allmodconfig build testing was done on x86-64, arm64,
x86-32, arm. powerpc, and mips on linux-next (and hence net-next).

Paul.

---

Cc: Alexei Starovoitov <ast@...nel.org>
Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
Cc: Cong Wang <xiyou.wangcong@...il.com>
Cc: Daniel Borkmann <daniel@...earbox.net>
Cc: Daniel Wagner <daniel.wagner@...-carit.de>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Cc: Jamal Hadi Salim <jhs@...atatu.com>
Cc: Jiri Pirko <jiri@...nulli.us>
Cc: Martin KaFai Lau <kafai@...com>
Cc: "Rosen, Rami" <rami.rosen@...el.com>
Cc: Song Liu <songliubraving@...com>
Cc: Tejun Heo <tj@...nel.org>
Cc: Yonghong Song <yhs@...com>
Cc: Yotam Gigi <yotam.gi@...il.com>

Paul Gortmaker (7):
  net: psample: drop include of module.h from psample.h
  net: ife: drop include of module.h from net/ife.h
  net: fib: drop include of module.h from fib_notifier.h
  net: tc_act: drop include of module.h from tc_ife.h
  cgroup: net: remove left over MODULE_LICENSE tag
  net: bpfilter: dont use module_init in non-modular code
  net: strparser: make it explicitly non-modular

 include/net/fib_notifier.h  |  3 ++-
 include/net/ife.h           |  1 -
 include/net/psample.h       |  1 -
 include/net/tc_act/tc_ife.h |  3 ++-
 net/core/netprio_cgroup.c   |  2 --
 net/ipv4/bpfilter/sockopt.c |  3 +--
 net/strparser/strparser.c   | 14 ++++----------
 7 files changed, 9 insertions(+), 18 deletions(-)

-- 
2.7.4

Powered by blists - more mailing lists