lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Apr 2019 23:29:43 -0400 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: "David S. Miller" <davem@...emloft.net> CC: <netdev@...r.kernel.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Yotam Gigi <yotam.gi@...il.com>, Jamal Hadi Salim <jhs@...atatu.com> Subject: [PATCH 2/7] net: ife: drop include of module.h from net/ife.h Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP. The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support. There doesn't appear to be anything in net/ife.h that is module related, and build coverage doesn't appear to show any other files/drivers relying implicitly on getting it from here. So it appears we are simply free to just remove it in this case. Cc: Yotam Gigi <yotam.gi@...il.com> Cc: Jamal Hadi Salim <jhs@...atatu.com> Cc: "David S. Miller" <davem@...emloft.net> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> --- include/net/ife.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/ife.h b/include/net/ife.h index e117617e3c34..7e2538d8585b 100644 --- a/include/net/ife.h +++ b/include/net/ife.h @@ -4,7 +4,6 @@ #include <linux/etherdevice.h> #include <linux/rtnetlink.h> -#include <linux/module.h> #include <uapi/linux/ife.h> #if IS_ENABLED(CONFIG_NET_IFE) -- 2.7.4
Powered by blists - more mailing lists