netdev - Re: [PATCH v2] net: stmmac: move stmmac_check_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Apr 2019 15:30:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org,
        Xiaofei Shen <xiaofeis@...eaurora.org>,
        Sneh Shah <snehshah@...eaurora.org>
Subject: Re: [PATCH v2] net: stmmac: move stmmac_check_ether_addr() to driver
 probe

On Mon, Apr 22, 2019 at 03:15:32PM +0530, Vinod Koul wrote:
> stmmac_check_ether_addr() checks the MAC address and assigns one in
> driver open(). In many cases when we create slave netdevice, the dev
> addr is inherited from master but the master dev addr maybe NULL at
> that time, so move this call to driver probe so that address is
> always valid.
> 
> Signed-off-by: Xiaofei Shen <xiaofeis@...eaurora.org>
> Tested-by: Xiaofei Shen <xiaofeis@...eaurora.org>
> Signed-off-by: Sneh Shah <snehshah@...eaurora.org>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>

Thanks for doing it this way.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew