netdev - Re: [PATCH v2] net: stmmac: move stmmac_check_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190422.215321.788755999613732980.davem@davemloft.net>
Date:   Mon, 22 Apr 2019 21:53:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vkoul@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        niklas.cassel@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, xiaofeis@...eaurora.org,
        snehshah@...eaurora.org
Subject: Re: [PATCH v2] net: stmmac: move stmmac_check_ether_addr() to
 driver probe

From: Vinod Koul <vkoul@...nel.org>
Date: Mon, 22 Apr 2019 15:15:32 +0530

> stmmac_check_ether_addr() checks the MAC address and assigns one in
> driver open(). In many cases when we create slave netdevice, the dev
> addr is inherited from master but the master dev addr maybe NULL at
> that time, so move this call to driver probe so that address is
> always valid.
> 
> Signed-off-by: Xiaofei Shen <xiaofeis@...eaurora.org>
> Tested-by: Xiaofei Shen <xiaofeis@...eaurora.org>
> Signed-off-by: Sneh Shah <snehshah@...eaurora.org>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
> 
> Changes in v2:
>   As discussed in [1] we move the stmmac driver inherting the mac address
> from probe to open
> [1]: https://lore.kernel.org/netdev/20190222125654.12478-1-vkoul@kernel.org/

Applied and queued up for -stable.