netdev - Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190423190947.GJ2677@nanopsycho.orion>
Date:   Tue, 23 Apr 2019 21:09:47 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add
 new and delete devices

Tue, Apr 23, 2019 at 07:06:42PM CEST, jakub.kicinski@...ronome.com wrote:
>On Tue, 23 Apr 2019 08:29:23 +0200, Jiri Pirko wrote:
>> Mon, Apr 22, 2019 at 09:23:02PM CEST, jakub.kicinski@...ronome.com wrote:
>> >On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote:  
>> >> +static ssize_t del_device_store(struct bus_type *bus, const char *buf,
>> >> +				size_t count)  
>> >
>> >Please use the existing format of breaking  multiline function
>> >declaration, if retype is longer than 3 chars it should be on a
>> >separate line:  
>> 
>> Where is it written down? First time I hear about such rule.
>
>That's sort of my rule, for code I maintain.  The general rule of 
>the thumb is follow the formatting of the existing code..

Okay. Will do :)