netdev - Re: [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to readout chip temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190423191250.GK28405@lunn.ch>
Date:   Tue, 23 Apr 2019 21:12:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
        Yana Esina <yana.esina@...antia.com>
Subject: Re: [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to
 readout chip temperature

On Tue, Apr 23, 2019 at 01:17:29PM +0000, Igor Russkikh wrote:
> From: Yana Esina <yana.esina@...antia.com>
> 
> Ability to read the chip temperature from memory
> via hwmon interface
> 
> Signed-off-by: Yana Esina <yana.esina@...antia.com>
> Signed-off-by: Nikita Danilov <nikita.danilov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>
> ---
>  .../net/ethernet/aquantia/atlantic/aq_hw.h    |  2 ++
>  .../aquantia/atlantic/hw_atl/hw_atl_utils.c   |  1 +
>  .../atlantic/hw_atl/hw_atl_utils_fw2x.c       | 36 +++++++++++++++++++
>  3 files changed, 39 insertions(+)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> index 81aab73dc22f..538593261ae3 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> @@ -259,6 +259,8 @@ struct aq_fw_ops {
>  
>  	int (*update_stats)(struct aq_hw_s *self);
>  
> +	int (*get_temp)(struct aq_hw_s *self, int *temp);
> +

We talked about renaming this get_phy_temp so you could later add
get_mac_temp?

	Andrew