lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190423191758.GL28405@lunn.ch> Date: Tue, 23 Apr 2019 21:17:58 +0200 From: Andrew Lunn <andrew@...n.ch> To: Igor Russkikh <Igor.Russkikh@...antia.com> Cc: "David S . Miller" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Nikita Danilov <Nikita.Danilov@...antia.com>, Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>, Yana Esina <yana.esina@...antia.com> Subject: Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature > +static u32 aq_hwmon_temp_config[] = { > + HWMON_T_INPUT | HWMON_T_LABEL, > + 0, It would be nice to also have HWMON_T_MAX | HWMON_T_MIN | HWMON_T_CRIT | HWMON_T_LCRIT | which the PHY probably has. At gives some degree of context. A temperature on its own of say 65C is hard to interpret. Is it too hot? But if we have a critical of 85C and a max of 95C we know we are O.K. Andrew
Powered by blists - more mailing lists