lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 23 Apr 2019 17:37:25 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>
Subject: Re: [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into
 work job

On Tue, 23 Apr 2019 13:17:55 +0000, Igor Russkikh wrote:
> Service timer callback fetches statistics from FW and that may cause
> a long delay in error cases. We also now need to use fw mutex
> to prevent concurrent access to FW, thus - extract that logic
> from timer callback into the job in the separate work queue.
> 
> Signed-off-by: Nikita Danilov <ndanilov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>

The split into patches is slightly imperfect here.

Patch 10 "introduces" a mutex, which nothing is using, yet.

Patch 11 starts some async work, which the mutex is needed for.

Patches 12 and 13 wrap other FW call sites...

Isn't it better to squash 12 and 13 into 10, this way 11 is safe 
to access FW from the work queue?

Powered by blists - more mailing lists