netdev - Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffe68770-3cb8-5468-1ad6-23ccda4fcfe0@aquantia.com>
Date:   Wed, 24 Apr 2019 08:28:46 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
        Yana Esina <yana.esina@...antia.com>
Subject: Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for
 chip temperature


>> +static u32 aq_hwmon_temp_config[] = {
>> +	HWMON_T_INPUT | HWMON_T_LABEL,
>> +	0,
> 
> It would be nice to also have
> 
>         HWMON_T_MAX | HWMON_T_MIN |
>         HWMON_T_CRIT | HWMON_T_LCRIT |
> 
> which the PHY probably has.
> 
> At gives some degree of context. A temperature on its own of say 65C
> is hard to interpret. Is it too hot?  But if we have a critical of 85C
> and a max of 95C we know we are O.K.

I can give here only suggested constants, since we don't have now any interface
on reading/configuring these.

Do you think that will be ok?

Regards,
  Igor