lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 22 Apr 2019 21:40:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ard.biesheuvel@...aro.org
Cc:     ilias.apalodimas@...aro.org, netdev@...r.kernel.org,
        jaswinder.singh@...aro.org, masahisa.kojima@...aro.org
Subject: Re: [PATCH] net: socionext: replace napi_alloc_frag with the
 netdev variant on init

From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Date: Fri, 19 Apr 2019 08:46:40 +0200

> On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas
> <ilias.apalodimas@...aro.org> wrote:
>>
>> Hi Ard,
>> > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag
>> > >
>> >
>> > Why?
>> >
>> The netdev variant is usable on any context since it disables interrupts.
>> The napi variant of the call is supposed to be used under softirq context
>> only
>>
> 
> Helpful, thanks. In general, commit logs need to describe *why* you do
> something, since *what* you do is usually obvious from the patch
> itself, but why you do it isn't.
> 
> With the above clarification added:
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Just being clear, this patch needs to be reposted with the commit log extended
as requested.

Thank you.

Powered by blists - more mailing lists