netdev - Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJe_Zhf9fK7nij4WiFwuhffKxhyqo2By5d1v0u0RVkLrhyGeNg@mail.gmail.com>
Date:   Fri, 19 Apr 2019 18:48:13 -0500
From:   Jassi Brar <jaswinder.singh@...aro.org>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Masahisa Kojima <masahisa.kojima@...aro.org>
Subject: Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev
 variant on init

On Fri, 19 Apr 2019 at 01:46, Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:
>
> On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas
> <ilias.apalodimas@...aro.org> wrote:
> >
> > Hi Ard,
> > > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag
> > > >
> > >
> > > Why?
> > >
> > The netdev variant is usable on any context since it disables interrupts.
> > The napi variant of the call is supposed to be used under softirq context
> > only
> >
>
> Helpful, thanks. In general, commit logs need to describe *why* you do
> something, since *what* you do is usually obvious from the patch
> itself, but why you do it isn't.
>
> With the above clarification added:
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>
Fine by me too.

Acked-by: Jassi Brar <jaswinder.singh@...aro.org>

Thanks.