netdev - Re: [PATCH net-next] lwtunnel: Pass encap and encap type attributes to lwtunnel_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190423.194245.1627236782046166441.davem@davemloft.net>
Date:   Tue, 23 Apr 2019 19:42:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net-next] lwtunnel: Pass encap and encap type
 attributes to lwtunnel_fill_encap

From: David Ahern <dsahern@...nel.org>
Date: Tue, 23 Apr 2019 08:23:41 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Currently, lwtunnel_fill_encap hardcodes the encap and encap type
> attributes as RTA_ENCAP and RTA_ENCAP_TYPE, respectively. The nexthop
> objects want to re-use this code but the encap attributes passed to
> userspace as NHA_ENCAP and NHA_ENCAP_TYPE. Since that is the only
> difference, change lwtunnel_fill_encap to take the attribute type as
> an input.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Looks great, applied.