netdev - Re: [PATCH net-next] net: Change nhc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 19:44:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, dsahern@...il.com
Subject: Re: [PATCH net-next] net: Change nhc_flags to unsigned char

From: David Ahern <dsahern@...nel.org>
Date: Tue, 23 Apr 2019 08:48:09 -0700

> From: David Ahern <dsahern@...il.com>
> 
> nhc_flags holds the RTNH_F flags for a given nexthop (fib{6}_nh).
> All of the RTNH_F_ flags fit in an unsigned char, and since the API to
> userspace (rtnh_flags and lower byte of rtm_flags) is 1 byte it can not
> grow. Make nhc_flags in fib_nh_common an unsigned char and shrink the
> size of the struct by 8, from 56 to 48 bytes.
> 
> Update the flags arguments for up netdevice events and fib_nexthop_info
> which determines the RTNH_F flags to return on a dump/event. The RTNH_F
> flags are passed in the lower byte of rtm_flags which is an unsigned int
> so use a temp variable for the flags to fib_nexthop_info and combine
> with rtm_flags in the caller.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Also applied, thanks David.