netdev - Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e0cf9ba98260309c43d9d6e63dead6c@codeaurora.org>
Date:   Wed, 24 Apr 2019 14:19:08 +0800
From:   Rocky Liao <rjliao@...eaurora.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        thierry.escande@...aro.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property
 firmware-name for QCA6174

On 2019-04-24 01:06, Marcel Holtmann wrote:
> Hi Rocky,
> 
>> This patch adds an optional device property "firmware-name" to allow 
>> the
>> driver to load customized nvm firmware file based on this property.
>> 
>> Signed-off-by: Rocky Liao <rjliao@...eaurora.org>
>> ---
>> Changes in v3:
>>  * added firmware-name instead of nvm-postfix to specify full firmware 
>> name
>> ---
>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt 
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 824c0e2..2bcea50 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -16,6 +16,7 @@ Optional properties for compatible string 
>> qcom,qca6174-bt:
>> 
>>  - enable-gpios: gpio specifier used to enable chip
>>  - clocks: clock provided to the controller (SUSCLK_32KHZ)
>> + - firmware-name: specify the name of nvm firmware to load
>> 
>> Required properties for compatible string qcom,wcn3990-bt:
>> 
>> @@ -39,6 +40,7 @@ serial@...0000 {
>> 
>> 		enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>> 		clocks = <&divclk4>;
>> +		firmware-name = "nvm_00440302.bin";
>> 	};
> 
> and how is this a firmware-name property. Wouldn’t this be more like
> nvm-file or something along these lines. This really needs to be
> cleared with Rob to pick the right property name.
> 
> Regards
> 
> Marcel

Hi Rob,

Are you OK to use a property name "nvm-file" or "firmware-nvm-file"? 
Actually we have two firmware files, one is the patch file which is 
common to all of the products, the other is the nvm file which is 
customized. Using a "nvm-file" or "firmware-nvm-file" property name 
would be more clear.

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project