netdev - Re: TC stats / hw offload question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Apr 2019 00:33:46 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: TC stats / hw offload question

On Thu, Apr 25, 2019 at 02:23:08PM +0100, Edward Cree wrote:
> On 24/04/2019 16:03, Edward Cree wrote:
> > static int efx_tc_flower_replace(struct efx_nic *efx,
> >                                  struct net_device *net_dev,
> >                                  struct tc_cls_flower_offload *tc)
> > {
> >     struct efx_tc_action_set *act;
> >
> >     /* parse the match */
> >
> >     tcf_exts_for_each_action(i, a, tc->exts) {
> >         if (a->ops && a->ops->stats_update) {
> >             /* act is the hw action we're building */
> >             act->count = allocate_a_counter();
>
> Also, this was actually taking a->tcfa_index, allowing multiple rules to
>  share a counter.  The action index doesn't seem to be available in the
>  new flow_offload API.

Could you show a bit more code to see how you use a->tcfa_index from
your efx_tc_flower_replace()?

Thanks.