netdev - Re: TC stats / hw offload question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58c74d0f-b92e-31f9-9828-24fb04129534@solarflare.com>
Date:   Thu, 25 Apr 2019 14:23:08 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
CC:     Jamal Hadi Salim <jhs@...atatu.com>,
        netdev <netdev@...r.kernel.org>, "Jiri Pirko" <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: TC stats / hw offload question

On 24/04/2019 16:03, Edward Cree wrote:
> static int efx_tc_flower_replace(struct efx_nic *efx,
>                                  struct net_device *net_dev,
>                                  struct tc_cls_flower_offload *tc)
> {
>     struct efx_tc_action_set *act;
>
>     /* parse the match */
>
>     tcf_exts_for_each_action(i, a, tc->exts) {
>         if (a->ops && a->ops->stats_update) {
>             /* act is the hw action we're building */
>             act->count = allocate_a_counter();
Also, this was actually taking a->tcfa_index, allowing multiple rules to
 share a counter.  The action index doesn't seem to be available in the
 new flow_offload API.

-Ed