lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190426114824.B271C602F5@smtp.codeaurora.org> Date: Fri, 26 Apr 2019 11:48:24 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Kangjie Lu <kjlu@....edu> Cc: kjlu@....edu, pakki001@....edu, "David S. Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: wireless: fix missing checks for ioremap Kangjie Lu <kjlu@....edu> wrote: > ioremap could fail and returns NULL. The fix actively checks > its return value and handles potential failures. > > Signed-off-by: Kangjie Lu <kjlu@....edu> The prefix should be "ray_cs: ": https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong Also I don't see the point of setting the ret variable as it's ignored in the failed label: failed: ray_release(link); return -ENODEV; Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10846851/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists