lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87k1fhugq0.fsf@kamboji.qca.qualcomm.com> Date: Fri, 26 Apr 2019 14:51:51 +0300 From: Kalle Valo <kvalo@...eaurora.org> To: Kangjie Lu <kjlu@....edu> Cc: netdev@...r.kernel.org, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org, pakki001@....edu, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] net: ath: fix missing checks for bmi reads and writes Kangjie Lu <kjlu@....edu> writes: > ath10k_bmi_write32 and ath10k_bmi_read32 can fail. The fix > checks their statuses to avoid potential undefined behaviors. > > Signed-off-by: Kangjie Lu <kjlu@....edu> [...] > @@ -2500,8 +2515,15 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode, > if (status) > goto err; > > - if (ar->hif.bus == ATH10K_BUS_SDIO) > - ath10k_init_sdio(ar); > + if (ar->hif.bus == ATH10K_BUS_SDIO) { > + status = ath10k_init_sdio(ar); > + if (status) { > + ath10k_err(ar, > + "could not init HTC (%d)\n", > + status); I'll fix the warning message as well, we are not initialisating HTC here. -- Kalle Valo
Powered by blists - more mailing lists