netdev - Re: [PATCH net-next 2/7] ipv4: Pass fib_nh_common to rt_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 27 Apr 2019 15:32:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        idosch@...lanox.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 2/7] ipv4: Pass fib_nh_common to rt_cache_route

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/David-Ahern/ipv4-ipv6-Move-location-of-pcpu-route-cache-and-exceptions/20190427-143626
config: i386-randconfig-x077-201916 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/ipv4/route.c: In function 'rt_set_nexthop':
>> net/ipv4/route.c:1594:25: error: 'struct fib_nh' has no member named 'nh_tclassid'
       rt->dst.tclassid = nh->nh_tclassid;
                            ^~

vim +1594 net/ipv4/route.c

d2d68ba9 David S. Miller  2012-07-17  1567  
f2bb4bed David S. Miller  2012-07-17  1568  static void rt_set_nexthop(struct rtable *rt, __be32 daddr,
5e2b61f7 David S. Miller  2011-03-04  1569  			   const struct fib_result *res,
f2bb4bed David S. Miller  2012-07-17  1570  			   struct fib_nh_exception *fnhe,
a4c2fd7f Wei Wang         2017-06-17  1571  			   struct fib_info *fi, u16 type, u32 itag,
a4c2fd7f Wei Wang         2017-06-17  1572  			   const bool do_cache)
^1da177e Linus Torvalds   2005-04-16  1573  {
caacf05e David S. Miller  2012-07-31  1574  	bool cached = false;
caacf05e David S. Miller  2012-07-31  1575  
^1da177e Linus Torvalds   2005-04-16  1576  	if (fi) {
eba618ab David Ahern      2019-04-02  1577  		struct fib_nh_common *nhc = FIB_RES_NHC(*res);
4895c771 David S. Miller  2012-07-17  1578  
0f5f7d7b David Ahern      2019-04-05  1579  		if (nhc->nhc_gw_family && nhc->nhc_scope == RT_SCOPE_LINK) {
0f5f7d7b David Ahern      2019-04-05  1580  			rt->rt_gw_family = nhc->nhc_gw_family;
0f5f7d7b David Ahern      2019-04-05  1581  			/* only INET and INET6 are supported */
0f5f7d7b David Ahern      2019-04-05  1582  			if (likely(nhc->nhc_gw_family == AF_INET))
0f5f7d7b David Ahern      2019-04-05  1583  				rt->rt_gw4 = nhc->nhc_gw.ipv4;
0f5f7d7b David Ahern      2019-04-05  1584  			else
0f5f7d7b David Ahern      2019-04-05  1585  				rt->rt_gw6 = nhc->nhc_gw.ipv6;
155e8336 Julian Anastasov 2012-10-08  1586  		}
0f5f7d7b David Ahern      2019-04-05  1587  
e1255ed4 David Ahern      2018-10-04  1588  		ip_dst_init_metrics(&rt->dst, fi->fib_metrics);
e1255ed4 David Ahern      2018-10-04  1589  
cd83562e David Ahern      2019-04-26  1590  		if (IS_ENABLED(CONFIG_IP_ROUTE_CLASSID)) {
cd83562e David Ahern      2019-04-26  1591  			struct fib_nh *nh;
cd83562e David Ahern      2019-04-26  1592  
0f5f7d7b David Ahern      2019-04-05  1593  			nh = container_of(nhc, struct fib_nh, nh_common);
f2bb4bed David S. Miller  2012-07-17 @1594  			rt->dst.tclassid = nh->nh_tclassid;
cd83562e David Ahern      2019-04-26  1595  		}
cd83562e David Ahern      2019-04-26  1596  
cd83562e David Ahern      2019-04-26  1597  		rt->dst.lwtstate = lwtstate_get(nhc->nhc_lwtstate);
c5038a83 David S. Miller  2012-07-31  1598  		if (unlikely(fnhe))
a4c2fd7f Wei Wang         2017-06-17  1599  			cached = rt_bind_exception(rt, fnhe, daddr, do_cache);
a4c2fd7f Wei Wang         2017-06-17  1600  		else if (do_cache)
cd83562e David Ahern      2019-04-26  1601  			cached = rt_cache_route(nhc, rt);
155e8336 Julian Anastasov 2012-10-08  1602  		if (unlikely(!cached)) {
155e8336 Julian Anastasov 2012-10-08  1603  			/* Routes we intend to cache in nexthop exception or
155e8336 Julian Anastasov 2012-10-08  1604  			 * FIB nexthop have the DST_NOCACHE bit clear.
155e8336 Julian Anastasov 2012-10-08  1605  			 * However, if we are unsuccessful at storing this
155e8336 Julian Anastasov 2012-10-08  1606  			 * route into the cache we really need to set it.
155e8336 Julian Anastasov 2012-10-08  1607  			 */
1550c171 David Ahern      2019-04-05  1608  			if (!rt->rt_gw4) {
1550c171 David Ahern      2019-04-05  1609  				rt->rt_gw_family = AF_INET;
1550c171 David Ahern      2019-04-05  1610  				rt->rt_gw4 = daddr;
1550c171 David Ahern      2019-04-05  1611  			}
155e8336 Julian Anastasov 2012-10-08  1612  			rt_add_uncached_list(rt);
d33e4553 David S. Miller  2010-12-14  1613  		}
155e8336 Julian Anastasov 2012-10-08  1614  	} else
caacf05e David S. Miller  2012-07-31  1615  		rt_add_uncached_list(rt);
defb3519 David S. Miller  2010-12-08  1616  

:::::: The code at line 1594 was first introduced by commit
:::::: f2bb4bedf35d5167a073dcdddf16543f351ef3ae ipv4: Cache output routes in fib_info nexthops.

:::::: TO: David S. Miller <davem@...emloft.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28546 bytes)