netdev - Re: [PATCH v4 bpf-next 0/7] BPF sk local storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0489bd3-1b30-7a50-4ec4-9b5e95459149@fb.com>
Date:   Sat, 27 Apr 2019 16:01:23 +0000
From:   Yonghong Song <yhs@...com>
To:     Martin Lau <kafai@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Alexei Starovoitov <ast@...com>, Andrii Nakryiko <andriin@...com>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Kernel Team <Kernel-team@...com>,
        Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [PATCH v4 bpf-next 0/7] BPF sk local storage



On 4/26/19 4:39 PM, Martin KaFai Lau wrote:
> v4:
> - Move checks to map_alloc_check in patch 1 (Stanislav Fomichev)
> - Refactor BTF encoding macros to test_btf.h at
>    a new patch 4 (Stanislav Fomichev)
> - Refactor getenv and add print PASS message at the
>    end of the test in patch 6 (Yonghong Song)
> 
> v3:
> - Replace spinlock_types.h with spinlock.h in patch 1
>    (kbuild test robot <lkp@...el.com>)
> 
> v2:
> - Add the "test_maps.h" file in patch 5
> 
> This series introduces the BPF sk local storage.  The
> details is in the patch 1 commit message.
> 
> Martin KaFai Lau (7):
>    bpf: Introduce bpf sk local storage
>    bpf: Sync bpf.h to tools
>    bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing
>    bpf: Refactor BTF encoding macro to test_btf.h
>    bpf: Add verifier tests for the bpf_sk_storage
>    bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps
>    bpf: Add ene-to-end test for bpf_sk_storage_* helpers

Looks good to me. Ack the whole series.

Acked-by: Yonghong Song <yhs@...com>

> 
>   include/linux/bpf.h                           |   2 +
>   include/linux/bpf_types.h                     |   1 +
>   include/net/bpf_sk_storage.h                  |  13 +
>   include/net/sock.h                            |   5 +
>   include/uapi/linux/bpf.h                      |  44 +-
>   kernel/bpf/syscall.c                          |   3 +-
>   kernel/bpf/verifier.c                         |  27 +-
>   net/bpf/test_run.c                            |   2 +
>   net/core/Makefile                             |   1 +
>   net/core/bpf_sk_storage.c                     | 804 ++++++++++++++++++
>   net/core/filter.c                             |  12 +
>   net/core/sock.c                               |   5 +
>   tools/bpf/bpftool/map.c                       |   1 +
>   tools/include/uapi/linux/bpf.h                |  44 +-
>   tools/lib/bpf/libbpf_probes.c                 |  74 +-
>   tools/testing/selftests/bpf/Makefile          |  25 +-
>   tools/testing/selftests/bpf/bpf_helpers.h     |   5 +
>   .../selftests/bpf/map_tests/sk_storage_map.c  | 629 ++++++++++++++
>   .../bpf/progs/test_sock_fields_kern.c         |  53 ++
>   tools/testing/selftests/bpf/test_btf.c        |  63 +-
>   tools/testing/selftests/bpf/test_btf.h        |  69 ++
>   tools/testing/selftests/bpf/test_maps.c       |  18 +-
>   tools/testing/selftests/bpf/test_maps.h       |  17 +
>   .../testing/selftests/bpf/test_sock_fields.c  | 115 ++-
>   tools/testing/selftests/bpf/test_verifier.c   |  55 +-
>   tools/testing/selftests/bpf/verifier/sock.c   | 116 +++
>   26 files changed, 2089 insertions(+), 114 deletions(-)
>   create mode 100644 include/net/bpf_sk_storage.h
>   create mode 100644 net/core/bpf_sk_storage.c
>   create mode 100644 tools/testing/selftests/bpf/map_tests/sk_storage_map.c
>   create mode 100644 tools/testing/selftests/bpf/test_btf.h
>   create mode 100644 tools/testing/selftests/bpf/test_maps.h
>