netdev - Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5db90ce0-d24a-4317-5d68-5169d496609a@gmail.com>
Date:   Sun, 28 Apr 2019 08:06:29 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Ahern <dsahern@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     idosch@...lanox.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route
 cache and exceptions



On 4/27/19 7:27 PM, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common
> to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4
> routes. This allows a fib6_nh struct to be used with both IPv4 and
> and IPv6 routes.
> 
> In addition pcpu caches and exception entries for IPv6 routes are
> moved from fib6_info to fib6_nh since they are really a function of
> the device and gateway. During the move of each, functions are
> refactored such that the core logic is in new helpers that take
> a fib6_nh versus a fib6_info.
>

I would prefer we fix the existing bugs before moving the code around,
otherwise stable teams work is going to be tough.

We have dozens of syzbot reports involving all this stuff.