lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Apr 2019 14:31:57 +0000 From: YueHaibing <yuehaibing@...wei.com> To: Grygorii Strashko <grygorii.strashko@...com>, Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, Andrew Lunn <andrew@...n.ch>, Ilias Apalodimas <ilias.apalodimas@...aro.org> CC: YueHaibing <yuehaibing@...wei.com>, <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: [PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() Change the call to PTR_ERR to access the value just tested by IS_ERR. Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") Signed-off-by: YueHaibing <yuehaibing@...wei.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> --- v2: add Fixes tag --- drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index c3cba46fac9d..e37680654a13 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -2381,7 +2381,7 @@ static int cpsw_probe(struct platform_device *pdev) clk = devm_clk_get(dev, "fck"); if (IS_ERR(clk)) { - ret = PTR_ERR(mode); + ret = PTR_ERR(clk); dev_err(dev, "fck is not found %d\n", ret); return ret; }
Powered by blists - more mailing lists