lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 29 Apr 2019 12:30:21 -0400 (EDT)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     YueHaibing <yuehaibing@...wei.com>
cc:     Grygorii Strashko <grygorii.strashko@...com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent
 IS_ERR and PTR_ERR in cpsw_probe()



On Mon, 29 Apr 2019, YueHaibing wrote:

> Change the call to PTR_ERR to access the value just tested by IS_ERR.

I assume you didn't find the problem just looking through the code by
hand.  If you used a tool, it would be really good to acknowledge the tool
that was used.  The tools don't come for free, and you don't pay for them.
The only payment that you can offer is to acknowledge that the tool was
used, which helps justify that the tool is useful and what it is useful
for.

julia

>
> Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> v2: add Fixes tag
> ---
>  drivers/net/ethernet/ti/cpsw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c3cba46fac9d..e37680654a13 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -2381,7 +2381,7 @@ static int cpsw_probe(struct platform_device *pdev)
>
>  	clk = devm_clk_get(dev, "fck");
>  	if (IS_ERR(clk)) {
> -		ret = PTR_ERR(mode);
> +		ret = PTR_ERR(clk);
>  		dev_err(dev, "fck is not found %d\n", ret);
>  		return ret;
>  	}
>
>
>
>

Powered by blists - more mailing lists