netdev - Re: [PATCH net-next] net: sched: Introduce act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXnXyfLZ2+gjDufbdMrZLgtf9uKbzbUf50Xm-2Go7maVw@mail.gmail.com>
Date:   Tue, 30 Apr 2019 14:47:32 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     "Kevin 'ldir' Darbyshire-Bryant" <ldir@...byshire-bryant.me.uk>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Shuah Khan <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next] net: sched: Introduce act_ctinfo action

On Sat, Apr 27, 2019 at 6:08 AM Kevin 'ldir' Darbyshire-Bryant
<ldir@...byshire-bryant.me.uk> wrote:
>
> ctinfo is a new tc filter action module.  It is designed to restore DSCPs
> stored in conntrack marks into the ipv4/v6 diffserv field.

I think we can retrieve any information from conntrack with such
a general name, including skb mark. So, as you already pick the
name ctinfo, please make it general rather than just DSCP.
You can add skb mark into your ctinfo too so that act_connmark
can be just replaced.

Your patch looks fine from a quick galance, please make sure
you run checkpatch.pl to keep your coding style aligned to Linux
kernel's, at least I don't think we accept C++ style comments.

Thanks.