lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190501134710.8938-4-sameehj@amazon.com> Date: Wed, 1 May 2019 16:47:05 +0300 From: <sameehj@...zon.com> To: <davem@...emloft.net>, <netdev@...r.kernel.org> CC: Sameeh Jubran <sameehj@...zon.com>, <dwmw@...zon.com>, <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>, <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>, <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>, <benh@...zon.com>, <akiyano@...zon.com> Subject: [PATCH V1 net 3/8] net: ena: fix: Free napi resources when ena_up() fails From: Sameeh Jubran <sameehj@...zon.com> ena_up() calls ena_init_napi() but does not call ena_del_napi() in case of failure. This causes a segmentation fault upon rmmod when netif_napi_del() is called. Fix this bug by calling ena_del_napi() before returning error from ena_up(). Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com> Signed-off-by: Sameeh Jubran <sameehj@...zon.com> --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index dbcd58ebd0a9..03244155f74c 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -1825,6 +1825,7 @@ static int ena_up(struct ena_adapter *adapter) err_setup_tx: ena_free_io_irq(adapter); err_req_irq: + ena_del_napi(adapter); return rc; } -- 2.17.1
Powered by blists - more mailing lists