lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 May 2019 16:47:06 +0300 From: <sameehj@...zon.com> To: <davem@...emloft.net>, <netdev@...r.kernel.org> CC: Sameeh Jubran <sameehj@...zon.com>, <dwmw@...zon.com>, <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>, <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>, <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>, <benh@...zon.com>, <akiyano@...zon.com> Subject: [PATCH V1 net 4/8] net: ena: fix incorrect test of supported hash function From: Sameeh Jubran <sameehj@...zon.com> ena_com_set_hash_function() tests if a hash function is supported by the device before setting it. The test returns the opposite result than needed. Reverse the condition to return the correct value. Also use the BIT macro instead of inline shift. Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com> Signed-off-by: Sameeh Jubran <sameehj@...zon.com> --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index b17d435de09f..f9bc0b831a1a 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -2195,7 +2195,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev) if (unlikely(ret)) return ret; - if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) { + if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) { pr_err("Func hash %d isn't supported by device, abort\n", rss->hash_func); return -EOPNOTSUPP; -- 2.17.1
Powered by blists - more mailing lists