netdev - Re: [PATCH v2] ss: add option to print socket information on one line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17702d09-ebfa-c3a4-e1a6-403a3c552e37@gmail.com>
Date:   Thu, 2 May 2019 17:11:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Josh Hunt <johunt@...mai.com>, stephen@...workplumber.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] ss: add option to print socket information on one line

On 4/30/19 7:38 PM, Josh Hunt wrote:
> Multi-line output in ss makes it difficult to search for things with
> grep. This new option will make it easier to find sockets matching
> certain criteria with simple grep commands.
> 
...

> 
> Signed-off-by: Josh Hunt <johunt@...mai.com>
> ---
> 
> v1 -> v2
> * Update long option to --oneline to match other ip tools as per David.
> 
>  man/man8/ss.8 |  3 +++
>  misc/ss.c     | 51 +++++++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 44 insertions(+), 10 deletions(-)
> 

> diff --git a/misc/ss.c b/misc/ss.c
> index 9cb3ee19e542..e8e7b62eb4a5 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -121,6 +121,7 @@ static int follow_events;
>  static int sctp_ino;
>  static int show_tipcinfo;
>  static int show_tos;
> +int oneline = 0;
>  

dropped the ' = 0' which is unnecessary and applied to iproute2-next.