netdev - Re: [PATCH net] udp: fix GRO packet of death

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24b9d33236fc8e7846386b70f104d6f40f083d51.camel@redhat.com>
Date:   Thu, 02 May 2019 10:24:23 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] udp: fix GRO packet of death

On Wed, 2019-05-01 at 18:56 -0700, Eric Dumazet wrote:
> syzbot was able to crash host by sending UDP packets with a 0 payload.
> 
> TCP does not have this issue since we do not aggregate packets without
> payload.
> 
> Since dev_gro_receive() sets gso_size based on skb_gro_len(skb)
> it seems not worth trying to cope with padded packets.

Ooops... I messed-up badly! Thanks Eric for fixing this.

(too late, still)

Acked-by: Paolo Abeni <pabeni@...hat.com>