netdev - Re: [PATCH net] udp: fix GRO packet of death

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190501.223127.269942837516364133.davem@davemloft.net>
Date:   Wed, 01 May 2019 22:31:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, pabeni@...hat.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] udp: fix GRO packet of death

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed,  1 May 2019 18:56:28 -0700

> syzbot was able to crash host by sending UDP packets with a 0 payload.
> 
> TCP does not have this issue since we do not aggregate packets without
> payload.
> 
> Since dev_gro_receive() sets gso_size based on skb_gro_len(skb)
> it seems not worth trying to cope with padded packets.
 ...
> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Ugh :(

Applied and queued up for -stable, thanks Eric.