netdev - RE: [RFC HACK] xfrm: make state refcounting percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB667020CB281B9132C45B0B448B350@VE1PR04MB6670.eurprd04.prod.outlook.com>
Date:   Fri, 3 May 2019 06:48:33 +0000
From:   Vakul Garg <vakul.garg@....com>
To:     Steffen Klassert <steffen.klassert@...unet.com>
CC:     Florian Westphal <fw@...len.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [RFC HACK] xfrm: make state refcounting percpu



> -----Original Message-----
> From: Steffen Klassert <steffen.klassert@...unet.com>
> Sent: Friday, May 3, 2019 12:16 PM
> To: Vakul Garg <vakul.garg@....com>
> Cc: Florian Westphal <fw@...len.de>; netdev@...r.kernel.org
> Subject: Re: [RFC HACK] xfrm: make state refcounting percpu
> 
> On Fri, May 03, 2019 at 06:34:29AM +0000, Vakul Garg wrote:
> > > -----Original Message-----
> > > From: Steffen Klassert <steffen.klassert@...unet.com>
> > >
> > > Also, is this a new problem or was it always like that?
> >
> > It is always like this. On 4-core, 8-core platforms as well, these atomics
> consume significant cpu
> > (8 core cpu usage is more than 4 core).
> 
> Ok, so it is not a regression. That's what I wanted to know.
> 
> Did the patch from Florian improve the situation?

Actually I could not get time to try it yet.
Also I do not find Florian's patch making refcount in 'struct dst' to be pcpu.
So I think it may not help....